Fixes for pgAdmin4 messages

From: Alexander Lakhin <exclusion(at)gmail(dot)com>
To: pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org>
Subject: Fixes for pgAdmin4 messages
Date: 2017-11-01 07:33:13
Message-ID: 96894545-721b-5f81-0198-05dd9a1de086@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Hello,

While translating the messages, I encountered some English messages,
that I think should be fixed.
Please consider applying the attached patches.
If you have any concerns or questions, I'm ready to explain all the
fixes proposed.

And I have a question - do you use some kind of style guide?
(Something like:
https://www.postgresql.org/docs/10/static/error-style-guide.html)
In particular, I'm confused with such messages:
This URL cannot be called directly!
This URL cannot be called directly.
...
Name must be specified.
Name must be specified!
...
Are there any reasons to use exclamation marks in some of the messages?
And if so, in which messages exactly they should be used?

Best regards,
------
Alexander Lakhin
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
01-fix-Couldnot.patch text/x-patch 1.3 KB
02-fix-missing-period.patch text/x-patch 1.0 KB
03-fix-missing-periods.patch text/x-patch 939 bytes
04-msg-consistency.patch text/x-patch 1.8 KB
05-fix-collation-validation.patch text/x-patch 1.1 KB
06-msg-consistency.patch text/x-patch 1.4 KB
07-fix-missing-period.patch text/x-patch 946 bytes
08-fix-typo-Packge.patch text/x-patch 846 bytes
09-fix-typo-Securitiy.patch text/x-patch 1.1 KB
10-msg-consistency.patch text/x-patch 992 bytes
11-fix-message-about-table-type.patch text/x-patch 1.2 KB
12-quote-table-name.patch text/x-patch 1.9 KB
13-add-missing-space.patch text/x-patch 1.4 KB
14-remove-excessive-spaces.patch text/x-patch 1.3 KB
15-fix-typos-terminate.patch text/x-patch 1.0 KB
16-remove-excessive-space.patch text/x-patch 1003 bytes
17-add-periods.patch text/x-patch 938 bytes
18-fix-message-correct-case.patch text/x-patch 642 bytes
19-fix-typo-fine.patch text/x-patch 722 bytes
20-fix-message-tool-not-tools.patch text/x-patch 1.4 KB
21-fix-message-correct-value.patch text/x-patch 886 bytes
22-remove-trailing-space.patch text/x-patch 985 bytes
23-add-ending-periods.patch text/x-patch 3.9 KB

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2017-11-01 09:04:43 Re: Fixes for pgAdmin4 messages
Previous Message Murtuza Zabuawala 2017-10-31 13:47:25 Re: PGAdmin4 - Shortcuts Mac