| From: | Sergey Tatarintsev <s(dot)tatarintsev(at)postgrespro(dot)ru> |
|---|---|
| To: | Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: pgbench with partitioned tables |
| Date: | 2025-02-11 08:10:07 |
| Message-ID: | 963175df-44d6-43fa-987e-bd3fd03ea8e5@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
08.02.2025 17:32, Álvaro Herrera пишет:
> On 2025-Feb-07, Melanie Plageman wrote:
>
>> Okay, I've stared at this a bit, and it seems basically fine the way
>> it is (I might add a bit more whitespace, clean up the commit message,
>> etc). So I'm interested in committing it. I will admit that having
>> never committed anything to pgbench, I'm a bit nervous. So, give me a
>> couple days to work up the nerve.
> Sounds good. I only wanted to say that I would use PQexecParams()
> instead of PQexec() in the new function, avoiding the psprintf and
> pfree, and also that initializing relkind to RELKIND_RELATION is strange
> and probably unnecessary.
>
Let it be so. I made the suggested changes (patch v4 attached)
--
With best regards,
Sergey Tatarintsev,
PostgresPro
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Fix-pgbench-client-side-data-generation-for-partitio.patch | text/x-patch | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bertrand Drouvot | 2025-02-11 08:51:15 | Re: Track the amount of time waiting due to cost_delay |
| Previous Message | Pavel Stehule | 2025-02-11 07:11:29 | Re: Re: proposal: schema variables |