Re: pgsql: Include information on buffer usage during planning phase, in EX

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Fujii Masao <fujii(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Include information on buffer usage during planning phase, in EX
Date: 2020-04-03 16:28:10
Message-ID: 960d41f4-155e-25e1-8ddc-318c1fe0cb03@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 2020/04/04 0:34, Tom Lane wrote:
> Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> writes:
>> Attached is the patch that changes explain.c as follows (i.e., removes
>> Buffers lines at all) to make it more stable.
>
>> ln := regexp_replace(ln, '\m\d+\M', 'N', 'g');
>> -- In sort output, the above won't match units-suffixed numbers
>> ln := regexp_replace(ln, '\m\d+kB', 'NkB', 'g');
>> - -- Text-mode buffers output varies depending on the system state
>> - ln := regexp_replace(ln, '^( +Buffers: shared)( hit=N)?( read=N)?', '\1 [read]');
>> + -- Ignore text-mode buffers output because it varies depending
>> + -- on the system state
>> + CONTINUE WHEN (ln ~ ' +Buffers: .*');
>> return next ln;
>> end loop;
>> end;
>
> Works for me.

Many thanks! Pushed.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2020-04-03 16:29:08 Re: pgsql: Document color support
Previous Message Fujii Masao 2020-04-03 16:27:09 pgsql: Improve stability of explain regression test.