| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Chapman Flack <chap(at)anastigmatix(dot)net>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com> |
| Subject: | Re: Re: proposal: variadic argument support for least, greatest function |
| Date: | 2019-03-04 14:39:46 |
| Message-ID: | 95b90015-8588-3668-3fd8-587afb85f2bf@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/1/19 3:59 AM, Chapman Flack wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: not tested
> Documentation: tested, passed
>
> For completeness, I'll mark this reviewed again. It passes installcheck-world, the latest patch addresses the suggestions from me, and is improved on the code-structure matters that Tom pointed out. I don't know if it will meet Tom's threshold for desirability overall, but that sounds like a committer call at this point, so I'll change it to RfC.
Both committers who have looked at this patch (Tom, and Andres in his
patch roundup [1]) recommend that it be rejected.
If no committer steps up in the next week I think we should mark it as
rejected.
Regards,
--
-David
david(at)pgmasters(dot)net
[1]
https://www.postgresql.org/message-id/20190214203752.t4hl574k6jlu4t25%40alap3.anarazel.de
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Verite | 2019-03-04 14:58:58 | Re: insensitive collations |
| Previous Message | Tomas Vondra | 2019-03-04 14:08:09 | Re: Online verification of checksums |