| From: | Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Etsuro Fujita <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>, Robert Haas <rhaas(at)postgresql(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |
| Date: | 2019-04-23 06:59:14 |
| Message-ID: | 95a8a6e710d4c94a0ea71f4687c6ac93e5132754.camel@cybertec.at |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Mon, 2019-04-22 at 14:07 -0700, Andres Freund wrote:
> How about just applying the patch from v12 on?
> > Then it is a behavior change in a major release, which is acceptable.
> > It requires the imaginary FDW above to add an empty BeginForeignInsert
> > callback function, but will unbreak FDW that slept through the change
> > that added COPY support.
>
> I fail to see the advantage. It'll still require FDWs to be fixed to
> work correctly for v11, but additionally adds another set of API
> differences that needs to be fixed by another set of FDWs. I think this
> ship simply has sailed.
I can accept that (having fixed my own FDW), but I am worried that it will
cause problems for FDW users. Well, I guess they can always avoid COPY if
they don't want FDWs to crash.
Yours,
Laurenz Albe
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2019-04-23 07:44:50 | Re: pgsql: Allow insert and update tuple routing and COPY for foreign table |
| Previous Message | Michael Paquier | 2019-04-23 06:47:20 | pgsql: Fix detection of passwords hashed with MD5 or SCRAM-SHA-256 |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-04-23 07:08:18 | Re: Regression test PANICs with master-standby setup on same machine |
| Previous Message | Amit Langote | 2019-04-23 06:18:15 | Re: pg_dump is broken for partition tablespaces |