| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Christoph Berg <myon(at)debian(dot)org>, Robert Haas <robertmhaas(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: Add basic TAP tests for psql's tab-completion logic. |
| Date: | 2020-01-09 16:19:57 |
| Message-ID: | 9594.1578586797@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 2020-01-09 16:50, Tom Lane wrote:
>> That would disable psql's tab completion, command editing, and history
>> altogether, which I doubt is what you want for production builds.
>> If we conclude we can't work around the testing issues for ancient
>> libedit, probably the right answer is to provide a switch to
>> disable just the test. I've been trying to dance around that
>> conclusion, but maybe we should just do it and move on.
> I think he means something like
> make check with_readline=no
> not for the actual build.
Oh, I see. I'd rather not codify that though, because it risks
problems if that symbol ever gets used any other way. I was
thinking of making the test script check for some independent
environment variable, say SKIP_READLINE_TESTS.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-01-09 16:57:09 | pgsql: Reconsider the representation of join alias Vars. |
| Previous Message | Robert Haas | 2020-01-09 16:13:38 | pgsql: Add pg_shmem_allocations view. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2020-01-09 16:21:56 | Re: Recognizing superuser in pg_hba.conf |
| Previous Message | Robert Haas | 2020-01-09 16:13:46 | Re: [HACKERS] pg_shmem_allocations view |