Re: Minor documentation error regarding streaming replication protocol

From: Jeff Davis <pgsql(at)j-davis(dot)com>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Brar Piening <brar(at)gmx(dot)de>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Andres Freund <andres(at)anarazel(dot)de>
Subject: Re: Minor documentation error regarding streaming replication protocol
Date: 2020-12-07 23:24:14
Message-ID: 9586435d5baf325918b33b6855cf58d051d2e0d3.camel@j-davis.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Thu, 2020-12-03 at 13:14 -0500, Bruce Momjian wrote:
> How do we mandate that? Just mention it in the docs and C comments?

Can't we just throw an error in pg_create_restore_point() if any high
bits are set? And perhaps error or Assert at a later point in case we
change the code in such a way as to let non-ASCII data in there.

This is probably the best approach, and it builds on your previous
patch (which already got consensus) rather than replacing it.

Regards,
Jeff Davis

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2020-12-07 23:31:06 Re: Commitfest statistics
Previous Message Andres Freund 2020-12-07 22:31:15 Re: [HACKERS] [PATCH] Generic type subscripting