Re: Upgrading pg_statistic to handle collation honestly

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Upgrading pg_statistic to handle collation honestly
Date: 2018-12-14 14:57:57
Message-ID: 9576.1544799477@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 12/12/2018 16:57, Tom Lane wrote:
>> + stats->attrcollid = exprCollation(index_expr);
>> + /* XXX should we consult indcollation instead? */

> After looking through this again, I think the answer here is "yes".

Yeah, I was leaning towards that as well, but hadn't written the extra
code needed to make it so. Will fix.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2018-12-14 15:18:37 Re: explain plans with information about (modified) gucs
Previous Message Stephen Frost 2018-12-14 14:52:22 Re: [HACKERS] REINDEX CONCURRENTLY 2.0