Re: explicit_bzero for sslpassword

From: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: explicit_bzero for sslpassword
Date: 2020-05-20 08:06:55
Message-ID: 953f15bb-0afb-8148-9425-0e47e3930d7a@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-05-20 07:56, Michael Paquier wrote:
> On Tue, May 19, 2020 at 02:33:40PM +0200, Daniel Gustafsson wrote:
>> Since commit 74a308cf5221f we use explicit_bzero on pgpass and connhost
>> password in libpq, but not sslpassword which seems an oversight. The attached
>> performs an explicit_bzero before freeing like the pattern for other password
>> variables.
>
> Good catch, let's fix that. I would like to apply your suggested fix,
> but let's see first if others have any comments.

Looks correct to me.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message shawn wang 2020-05-20 08:15:32 Re: [bug] Table not have typarray when created by single user mode
Previous Message Guillaume Lelarge 2020-05-20 08:06:01 Extensions not dumped when --schema is used