From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Bruce Momjian <bruce(at)momjian(dot)us> |
Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: More pgindent tweaks |
Date: | 2023-01-25 16:01:14 |
Message-ID: | 9525f1ed-ef9a-df41-4c67-cbf9aa8ab05e@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 2023-01-25 We 09:41, Bruce Momjian wrote:
> On Wed, Jan 25, 2023 at 08:59:44AM -0500, Andrew Dunstan wrote:
>> After I committed 1249371632 I thought that I should really go ahead and
>> do what I suggested and allow multiple exclude pattern files for
>> pgindent. One obvious case is to exclude an in tree meson build
>> directory. I also sometimes have other in tree objects I'd like to be
>> able exclude.
>>
>> The attached adds this ability. It also unifies the logic for finding
>> the regular exclude pattern file and the typedefs file.
>>
>> I took the opportunity to remove a badly thought out and dangerous
>> feature whereby the first non-option argument, if it's not a .c or .h
>> file, is taken as the typedefs file. That's particularly dangerous in a
>> situation where git is producing a list of files that have changed and
>> passing it on the command line to pgindent. I also removed a number of
>> extraneous blank lines.
> Can we make the pgindent options more visible, perhaps by adding them to
> pgindent.man or at least saying type pgindent --help?
Sure, will do.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | songjinzhou | 2023-01-25 16:22:06 | Re: Re: Support plpgsql multi-range in conditional control |
Previous Message | Tom Lane | 2023-01-25 15:53:09 | Re: Improve GetConfigOptionValues function |