| From: | "Joel Jacobson" <joel(at)compiler(dot)org> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: New "raw" COPY format |
| Date: | 2024-10-21 15:11:16 |
| Message-ID: | 95219616-d547-4204-9adf-bc5586a1053c@app.fastmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Oct 21, 2024, at 16:35, jian he wrote:
> make the ProcessCopyOptions process in following order:
> 1. Extract options from the statement node tree
> 2. checking each option, if not there set default value.
> 3. checking for interdependent options
>
> I still think
> making step2 aligned with the doc parameter section order will make it
> more readable.
>
> based on your patch
> (v12-0001-Refactor-ProcessCopyOptions-introduce-CopyFormat-enu.patch)
> I put some checking to step3, make step2 checking order aligned with doc.
Smart to move the interdependent check to the designated section for it,
that's exactly the right place for it.
Really nice the order in the code now is aligned with the doc order.
/Joel
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-10-21 16:00:30 | Re: [PATCH] Add array_reverse() function |
| Previous Message | vignesh C | 2024-10-21 15:09:53 | Re: Make default subscription streaming option as Parallel |