| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Greg Sabino Mullane <htamfids(at)gmail(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Michael Banck <mbanck(at)gmx(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Enable data checksums by default |
| Date: | 2024-10-07 09:37:04 |
| Message-ID: | 946E62B6-7F46-4505-9F03-21C5779A746D@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 3 Oct 2024, at 23:13, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Tue, Oct 01, 2024 at 11:15:02AM -0400, Peter Eisentraut wrote:
>> I have committed 0001 (the new option) and 0004 (the docs tweak). I think
>> there is consensus for the rest, too, but I'll leave it for a few more days
>> to think about. I guess the test failure has to be addressed.
>
> Here is a rebased patch with the test fix (for cfbot). I have made no
> other changes.
+ Data checksums are enabled by default. They can be
+ disabled by use of <option>--no-data-checksums</option>.
Nitpick, but I think this should be an xref like how we link to --no-locale in
the -E docs: <xref linkend="app-initdb-no-data-checksums"/> instead.
LGTM otherwise.
--
Daniel Gustafsson
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-10-07 09:42:41 | Re: Changing the state of data checksums in a running cluster |
| Previous Message | Dmitry Dolgov | 2024-10-07 09:26:41 | Re: System views for versions reporting |