Re: pg_verifybackup: TAR format backup verification

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Tue, Oct 1, 2024 at 1:32 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Yes, mamba thinks this is OK.

> Committed.

Sadly, it seems adder[1] is even pickier than mamba:

../pgsql/src/backend/backup/basebackup_incremental.c: In function \342\200\230CreateIncrementalBackupInfo\342\200\231:
../pgsql/src/backend/backup/basebackup_incremental.c:179:30: error: assignment to \342\200\230json_manifest_per_file_callback\342\200\231 {aka \342\200\230void (*)(JsonManifestParseContext *, const char *, long long unsigned int, pg_checksum_type, int, unsigned char *)\342\200\231} from incompatible pointer type \342\200\230void (*)(JsonManifestParseContext *, const char *, size_t, pg_checksum_type, int, uint8 *)\342\200\231 {aka \342\200\230void (*)(JsonManifestParseContext *, const char *, unsigned int, pg_checksum_type, int, unsigned char *)\342\200\231} [-Wincompatible-pointer-types]
179 | context->per_file_cb = manifest_process_file;
| ^

regards, tom lane

[1] https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=adder&dt=2024-10-02%2014%3A09%3A58