Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file

From: David Steele <david(at)pgmasters(dot)net>
To: "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Stephen Frost <sfrost(at)snowman(dot)net>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>, Michael Paquier <michael(at)paquier(dot)xyz>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, SATYANARAYANA NARLAPURAM <satyanarlapuram(at)gmail(dot)com>
Subject: Re: Postgres restart in the middle of exclusive backup and the presence of backup_label file
Date: 2021-12-01 16:27:42
Message-ID: 9427c6b3-5e0b-e27f-a2e7-ec1ebc00b582@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/30/21 18:31, Bossart, Nathan wrote:
> On 11/30/21, 2:58 PM, "David Steele" <david(at)pgmasters(dot)net> wrote:
>> I did figure out how to keep the safe part of exclusive backup (not
>> having to maintain a connection) while removing the dangerous part
>> (writing backup_label into PGDATA), but it was a substantial amount of
>> work and I felt that it had little chance of being committed.
>
> Do you think it's still worth trying to make it safe, or do you think
> we should just remove exclusive mode completely?

My preference would be to remove it completely, but I haven't gotten a
lot of traction so far.

>> Attaching the thread [1] that I started with a patch to remove exclusive
>> backup for reference.
>
> Ah, good, some light reading. :)

Sure, if you say so!

Regards,
-David

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2021-12-01 16:38:25 Re: RecoveryInProgress() has critical side effects
Previous Message Alvaro Herrera 2021-12-01 16:20:46 Re: Is it worth adding ReplicationSlot active_pid to ReplicationSlotPersistentData?