| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Christoph Berg <myon(at)debian(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Subject: | Re: Set log_line_prefix and application name in test drivers |
| Date: | 2016-09-29 02:48:29 |
| Message-ID: | 9421.1475117309@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> On 9/28/16 6:13 PM, Robert Haas wrote:
>> Christoph/Debian:
>> log_line_prefix = '%t [%p-%l] %q%u(at)%d '
>> Peter:
>> log_line_prefix = '%t [%p]: [%l] %qapp=%a '
> ...
> I don't know why it wants that "-1" there, and I'm actually not sure
> what the point of %l is in practice. Those are separate issues that are
> having their own lively discussions at times. I could drop the [%l]
> from my proposal if that causes concerns.
+1 for dropping %l --- seems to me that its main result is to add useless
bytes to the log. Surely if you need to match up lines from the same
process, that's not that hard as long as %p is in there.
I'd also vote for dropping "app=" out of the regression test version;
again, that seems like basically dead weight.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2016-09-29 02:48:45 | Re: [GENERAL] C++ port of Postgres |
| Previous Message | Michael Paquier | 2016-09-29 02:32:09 | Re: Fix checkpoint skip logic on idle systems by tracking LSN progress |