Re: Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.

From: Mikael Kjellström <mikael(dot)kjellstrom(at)mksoft(dot)nu>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Mikael Kjellström <mikael(dot)kjellstrom(at)gmail(dot)com>
Subject: Re: Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.
Date: 2016-04-27 22:44:03
Message-ID: 941b941a-3d66-5e80-58cf-c7b5c1988a0b@mksoft.nu
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 2016-04-28 00:15, Tom Lane wrote:
> Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com> writes:
>>> Also happens on OpenBSD 5.8. Isn't this a classic case where memmove
>>> is called for? Replacing the memcpy at line 617 with memmove makes
>>> the tests run successfully, but at first glance the other two
>>> instances of memcpy in run_permutation should also be changed to
>>> memmove, no?
>
> Yeah, that's clearly busted. Surprising that it has not failed on
> any other platforms.
>
>> Suggested patch attached.
>
> Will push in a moment.

And that seems to have done the trick. I started a manual run of HEAD
on curculio and now it's green on the build farm.

Thanks!

/Mikael

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2016-04-27 22:50:01 Re: Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.
Previous Message Tom Lane 2016-04-27 22:19:32 pgsql: Use memmove() not memcpy() to slide some pointers down.

Browse pgsql-hackers by date

  From Date Subject
Next Message David G. Johnston 2016-04-27 22:46:29 Re: Add jsonb_compact(...) for whitespace-free jsonb to text
Previous Message Tom Lane 2016-04-27 22:15:07 Re: Re: [COMMITTERS] pgsql: Modify the isolation tester so that multiple sessions can wait.