Re: extensible options syntax for replication parser?

From: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Sergei Kornilov <sk(at)zsrv(dot)org>, Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: extensible options syntax for replication parser?
Date: 2021-09-24 18:27:59
Message-ID: 9400af96-f834-74f9-2d5d-5f5f751fb6a5@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 9/24/21 10:36 PM, Robert Haas wrote:
> Here's v9, fixing the issue reported by Fujii Masao.

Please refer this scenario where publication on v14RC1  and subscription
on HEAD (w/patch)

--create a subscription with parameter two_phase=1 on HEAD

postgres=# CREATE SUBSCRIPTION r1015 CONNECTION 'dbname=postgres
host=localhost port=5454' PUBLICATION p WITH (two_phase=1);
NOTICE:  created replication slot "r1015" on publisher
CREATE SUBSCRIPTION
postgres=#

--check on 14RC1

postgres=# select two_phase from pg_replication_slots where
slot_name='r105';
 two_phase
-----------
 f
(1 row)

so are we silently ignoring this parameter as it is not supported on
v14RC/HEAD ? and if yes then why not we just throw an message like
ERROR:  unrecognized subscription parameter: "two_phase"

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message tushar 2021-09-24 18:38:19 Re: extensible options syntax for replication parser?
Previous Message Tom Lane 2021-09-24 18:14:52 Re: standby recovery fails (tablespace related) (tentative patch and discussion)