From: | Dave Page <dpage(at)pgadmin(dot)org> |
---|---|
To: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
Cc: | Maga Abdurakhmanov <maqdev(at)gmail(dot)com>, pgadmin-hackers(at)postgresql(dot)org |
Subject: | Re: SQL Syntax Highlight Configuration |
Date: | 2010-02-08 21:39:29 |
Message-ID: | 937d27e11002081339v61c9a4adx6be4d56656f6add9@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgadmin-hackers |
I should read more carefully :-(. Ignore my last paragraph.
On 2/8/10, Dave Page <dpage(at)pgadmin(dot)org> wrote:
> I object.
>
> The correct solution here is to use the colour configured in the
> OS/window manager.
>
> When that is done, we'll also need a way to allow the user to
> configure the syntax highlighting colours so they don't clash.
>
> On 2/8/10, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
>> Hi Maga,
>>
>> Le 07/02/2010 02:43, Maga Abdurakhmanov a écrit :
>>> [...]
>>> I'm tired to see always white background of SQL editor, while background
>>> color on my system has another color and is not so bright.
>>> So I implemented feature to allow custom configuration for SQL syntax
>>> highlight, default background and foreground colors.
>>>
>>> I hope you like it. See an attached patch and screenshot with options
>>> shown.
>>> I've tested it on Windows Vista, hope it works on other platforms too.
>>>
>>
>> I like it. Seems good to me. Works on Linux. I'm less sure for Mac OS X.
>> Anyways, the UI needs some more work:
>>
>> * if "Use system background color" is checked, the associated
>> wxColourPickerCtrl widgets should be disabled
>> * the same for "Use system foreground color"
>> * "Element colour x" doesn't mean anything to our users, the text
>> should be replaced with a better text (for example "SQL words",
>> "Text literals", or something better)
>>
>> When this is fixed, it'll be applied to the SVN (unless anyone objects).
>>
>> Thanks for working on this.
>>
>>
>> --
>> Guillaume.
>> http://www.postgresqlfr.org
>> http://dalibo.com
>>
>> --
>> Sent via pgadmin-hackers mailing list (pgadmin-hackers(at)postgresql(dot)org)
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>
>
> --
> Dave Page
> EnterpriseDB UK: http://www.enterprisedb.com
>
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Guillaume Lelarge | 2010-02-08 21:43:18 | Re: SQL Syntax Highlight Configuration |
Previous Message | Dave Page | 2010-02-08 21:37:45 | Re: SQL Syntax Highlight Configuration |