Re: Database reconnect patch

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: Database reconnect patch
Date: 2009-11-22 18:18:11
Message-ID: 937d27e10911221018s153f7692u2fd72eb29b5a170f@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

You might know the server/network is down, so making the reconnect
optional allows you to avoid a potentially long timeout.

It also makes it clear to the user that a reconnect is happening. You
can see that in the terminal with psql, but in the gui, it would be
easy to miss.

On 11/21/09, Guillaume Lelarge <guillaume(at)lelarge(dot)info> wrote:
> Le jeudi 19 novembre 2009 à 08:29:00, Dave Page a écrit :
>> The attached patch against svn trunk is a first cut WIP offering an
>> option in the main window to reconnect to the database server if the
>> connection is lost.
>>
>> I'd appreciate some feedback please, and some thought given to the
>> question "does this break anything in any non-obvious ways?"
>>
>
> I have tried it, and it works great. Anyways, I have one question: why does
> it
> ask if we want to reconnect? psql doesn't ask and try to reconnect as soon
> as
> it discovers the issue. I don't really understand what kind of issue a
> direct
> reconnect will bring us.
>
>
> --
> Guillaume.
> http://www.postgresqlfr.org
> http://dalibo.com
>

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Guillaume Lelarge 2009-11-22 21:42:02 Re: Database reconnect patch
Previous Message Guillaume Lelarge 2009-11-22 17:40:34 Next patch for 8.5 support: ALTER TABLE ... ALTER COLUMN ... SET STATISTICS DISTINCT