Re: [PATCH] "could not reattach to shared memory" on Windows

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Alvaro Herrera <alvherre(at)commandprompt(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Tsutomu Yamada <tsutomu(at)sraoss(dot)co(dot)jp>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] "could not reattach to shared memory" on Windows
Date: 2009-07-14 18:17:47
Message-ID: 937d27e10907141117v31155203i2465352e02876cdb@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tuesday, July 14, 2009, Alvaro Herrera <alvherre(at)commandprompt(dot)com> wrote:
> Tom Lane wrote:
>> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> > Tsutomu Yamada wrote:
>> >> This patch using VirtualAlloc()/VirtualFree() to avoid failing in
>> >> reattach to shared memory.
>>
>> > Since this fixes a very annoying bug present in older versions, I think
>> > this should be backpatched all the way back to 8.2.
>>
>> Agreed, but first we need some evidence that it actually fixes the
>> problem.  How can we acquire such evidence?
>
> Send the patch to the people who has reported trouble and see if it
> seems gone?  If somebody is able to build patched Win32 packages I could
> point a couple of guys in the spanish list to them.

I built a version which a guy is currently testing. He could reproduce
the bug easily, but last i heard, the patch was looking good.

Don't have the details here tho.

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2009-07-14 18:18:30 Re: [PATCH] "could not reattach to shared memory" on Windows
Previous Message Josh Berkus 2009-07-14 18:17:14 Re: Alpha release process