Re: [pgScript patch] Output + bug fix

From: Dave Page <dpage(at)pgadmin(dot)org>
To: Mickael Deloison <mdeloison(at)gmail(dot)com>
Cc: Magnus Hagander <magnus(at)hagander(dot)net>, pgadmin-hackers(at)postgresql(dot)org
Subject: Re: [pgScript patch] Output + bug fix
Date: 2009-03-07 08:59:27
Message-ID: 937d27e10903070059o4d3f3330nd533d78820322c5a@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

I meant 'code written in pgScript' that would exercise that c++
codepath, but i think i can work something out from your description
:)

On 3/6/09, Mickael Deloison <mdeloison(at)gmail(dot)com> wrote:
> 2009/3/6 Dave Page <dpage(at)pgadmin(dot)org>:
>> Sorry - I meant some pgScript code that would create a message so i
>> can figure out where it gets lost.
>>> Here is the code you requested, I removed the useless parts:
>>>
>>> pgQueryThread thread(m_app->connection(), stmt);
>>>
>>> if (thread.Create() == wxTHREAD_NO_ERROR)
>>> {
>>> if (thread.Run() == wxTHREAD_NO_ERROR)
>>> {
>>> // ...
>>> }
>>>
>>> if (thread.ReturnCode() != PGRES_COMMAND_OK
>>> && thread.ReturnCode() != PGRES_TUPLES_OK)
>>> {
>>> // ...
>>> wxString message(stmt + wxT("\n") +
>>> -->
>>> thread.GetMessagesAndClear().Strip(wxString::both));
>>> // ...
>>> (*m_cout) << message << wxT("\n");
>>> // ...
>>> }
>
> This was pgScript code. It's in
> pgadmin/pgscript/expressions/pgsExecute.cpp. This is the expression
> that executes a query: it displays the warning if the return code was
> not PGRES_COMMAND_OK or PGRES_TUPLES_OK.
>

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Mickael Deloison 2009-03-07 11:31:32 Re: [pgScript patch] Output + bug fix
Previous Message Mickael Deloison 2009-03-06 22:54:02 Re: [pgScript patch] Output + bug fix