| From: | "Dave Page" <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | "Ashesh D Vashi" <ashesh(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | "Guillaume Lelarge" <guillaume(at)lelarge(dot)info>, pgadmin-hackers <pgadmin-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH for CREATE DATABASE with COLLATE, CTYPE & CONNECTION LIMIT |
| Date: | 2008-11-18 13:12:16 |
| Message-ID: | 937d27e10811180512g648397f0w27dbf9713055c704@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Hi
On Tue, Nov 18, 2008 at 10:57 AM, Ashesh D Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Hi,
>
> Please find the updated patch.
Thanks - committed with minor changes:
- Change 'Collate' to 'Collation'
- There were still a couple of places in the code which changed the
connection limit to -1 if it was less than that. I've removed those -
so we can rely on the server to catch errors there (the behaviour is
more consistent this way).
Note that I did find that the server will accept connection limits of
< -1 anyway - I've reported this as a PG bug.
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh D Vashi | 2008-11-18 13:12:30 | Re: extending functionality strategy |
| Previous Message | svn | 2008-11-18 13:09:53 | SVN Commit by dpage: r7500 - in trunk/pgadmin3: . pgadmin/db pgadmin/dlg pgadmin/include/dlg pgadmin/include/parser pgadmin/include/schema pgadmin/schema pgadmin/ui |