Re: "Dangerous" hotkey in server status dialog

From: "Dave Page" <dpage(at)pgadmin(dot)org>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>
Cc: pgadmin-hackers(at)postgresql(dot)org
Subject: Re: "Dangerous" hotkey in server status dialog
Date: 2008-07-31 15:00:38
Message-ID: 937d27e10807310800x269b02f1tf9997bb4076f8be4@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

On Thu, Jul 31, 2008 at 3:50 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> If you select a row in the server status dialog and hit escape, pgadmin
> will ask to cancel the query.
>
> On every platform I've worked on, escape means close the dialog, not
> actually do something.
>
> I think this is becuase we are using wxID_CANCEL, which is the default
> mapping there. I think the proper solution is to invent our own id
> instead. Same for the one under locks. I can't see any reason why we're
> overloading this with the default behaviours.
>
> I'd go as far as calling this a bug and say we should probably backpatch
> a fix ;-)

+1

--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com

In response to

Browse pgadmin-hackers by date

  From Date Subject
Next Message Magnus Hagander 2008-07-31 15:01:54 Minimum height of server status dialog
Previous Message Magnus Hagander 2008-07-31 14:50:59 "Dangerous" hotkey in server status dialog