Re: [BUGS] BUG #3909: src\tools\msvc\clean.bat clears parse.h file

From: "Dave Page" <dpage(at)postgresql(dot)org>
To: "Magnus Hagander" <magnus(at)hagander(dot)net>
Cc: "Pavel Golub" <pavel(at)gf(dot)microolap(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [BUGS] BUG #3909: src\tools\msvc\clean.bat clears parse.h file
Date: 2008-02-05 21:47:16
Message-ID: 937d27e10802051347r33b063amb61476eb312db4d3@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On Feb 5, 2008 5:56 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
>
> Dave Page wrote:
> > On Feb 5, 2008 3:24 PM, Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> >> On Mon, Jan 28, 2008 at 06:27:05PM +0000, Pavel Golub wrote:
> >> I think a better solution is to add a parameter to clean.bat to make it
> >> work like "make clean" does. So you'd to "clean" when you mean "make
> >> clean", and "clean dist" when you mean "make distclean".
> >>
> >> Thoughts on this?
> >
> > Pretty sure I griped at you before about this, because when it removes
> > it, it fails to rebuild it the next time round, even on in an env like
> > mine which can build from CVS perfectly well. More than once I've had
> > to unpack the tarball again having run a clean.
>
> Uh, that would be a different issue, and I thought that one was fixed. I
> certainly clean/rebuild a lot, and it works just fine with the stuff
> coming out of cvs.
>
> The problem comes from if you remove *one* of the files but not *all* of
> them. We only trigger on one of them (unlike the makefile which triggers
> on all). But as long as they are all removed, it should be ok.
>
> Can you confirm if you actually still have that problem with 8.3.0?

Yup - run clean.bat, and then build.bat and the resulting build fails
because parser/parse.h is missing. Thats with the 8.3.0 tarball, which
built just fine prior to running clean. Bison and flex are in the
path.

/D

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Tom Lane 2008-02-05 21:54:19 Re: BUG #3928: INFORMATION_SCHEMA does not give results if a user is allowed only access via ROLE
Previous Message Heikki Linnakangas 2008-02-05 19:57:05 Re: BUG #3933: Update problem for 3 Foreign Keys referencing 1 field in another table (I'm not newbie in using SQL)

Browse pgsql-hackers by date

  From Date Subject
Next Message Ron Mayer 2008-02-05 21:54:17 Re: configurability of OOM killer
Previous Message Decibel! 2008-02-05 21:33:39 Re: configurability of OOM killer