| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
| Cc: | Robins Tharakan <tharakan(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Missing CFI in iterate_word_similarity() |
| Date: | 2022-09-02 12:57:00 |
| Message-ID: | 937735.1662123420@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Daniel Gustafsson <daniel(at)yesql(dot)se> writes:
> Placing code before declarations will generate a compiler warning, so the check
> must go after trgindex is declared. I've fixed that in the attached to get the
> cfbot green. Marking this ready for committer in the meantime.
I noticed the same thing, but sticking the CFI immediately after the
declaration didn't read well either. I was considering moving it to
the bottom of the loop instead of that. A possible objection is that
if there's ever a "continue;" in the loop, those iterations would bypass
the CFI; but we don't necessarily need a CFI every time.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-09-02 13:06:34 | Re: Missing CFI in iterate_word_similarity() |
| Previous Message | Alvaro Herrera | 2022-09-02 12:43:03 | Re: broken table formatting in psql |