Re: pgsql: Refactor all TAP test suites doing connection checks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Date: 2021-04-06 00:40:13
Message-ID: 936576.1617669613@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Michael Paquier <michael(at)paquier(dot)xyz> writes:
> On Mon, Apr 05, 2021 at 08:15:31PM -0400, Tom Lane wrote:
>> Dunno. Certainly most animals that enable TAP at all should be
>> running the "authentication" test, but those others all need to
>> be manually enabled, I believe. My own animals run the SSL test
>> but not LDAP or kerberos.

> The SSL tests have always sent down a query even for scenarios where
> the connection would fail, but they have used command_fails_like()
> rather than PostgresNode::psql. The puzzle does not seem complete.

Well, since it's a race condition it's obviously going to be sensitive to
machine speed. I think that Perl version, or more likely version of
IPC::Run or a related module, may enter into it too. prairiedog has
gotten through the tests several times since yesterday without failing,
yet it's significantly slower than the other PPC Mac I was able to
consistently reproduce the problem on. I don't think those two have
the same vintage of Perl installation, though, so Perl version seems
like a likely explanation.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2021-04-06 00:53:18 pgsql: Change PostgresNode::connect_fails() to never send down queries
Previous Message Thomas Munro 2021-04-06 00:30:48 Re: pgsql: Refactor all TAP test suites doing connection checks