A small issue in CommentCast function

From: Gokulakannan Somasundaram <gokul007(at)gmail(dot)com>
To: pgsql-hackers list <pgsql-hackers(at)postgresql(dot)org>
Subject: A small issue in CommentCast function
Date: 2009-11-29 14:22:38
Message-ID: 9362e74e0911290622o3a665e8as7a184ddcd2a2441e@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,
I think this is more of code uniformity issue. Nevertheless, i just
thought of putting it here.
In the CommentCast function, i think both sourcetype and targettype
should be in the arguments, whereas in the code, source type is made as the
name and the target type is passed in as argument. So both of them should
get stored in the objargs member of the CommentStmt struct.

Thanks,
Gokul.

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2009-11-29 14:35:34 Re: compile error with -DOPTIMIZER_DEBUG
Previous Message Bruce Momjian 2009-11-29 13:09:03 Re: Timezones (in 8.5?)