| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: make pg_createsubscriber option names more consistent |
| Date: | 2024-08-01 10:32:14 |
| Message-ID: | 93452f9f-7634-4e36-99e2-c8453c4ac862@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 31.07.24 11:15, Hayato Kuroda (Fujitsu) wrote:
> Dear Peter,
>
>> I propose to rename the pg_createsubscriber option --socket-directory to
>> --socketdir. This would make it match the equivalent option in
>> pg_upgrade. (It even has the same short option '-s'.)
>> pg_createsubscriber and pg_upgrade have a lot of common terminology and
>> a similar operating mode, so it would make sense to keep this consistent.
>
> +1. If so, should we say "default current dir." instead of "default current directory" in usage()
> because pg_upgrade says like that?
Committed with that change. Thanks.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrey M. Borodin | 2024-08-01 10:37:05 | Re: Add LSN <-> time conversion functionality |
| Previous Message | Pradeep Kumar | 2024-08-01 09:59:20 | Re: rare crash - FailedAssertion snapbuild.c Line: 580 |