| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: pgsql: Add a regression test for allow_system_table_mods |
| Date: | 2019-12-03 08:30:22 |
| Message-ID: | 933c8484-76f8-b082-b206-772905a057a4@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
On 2019-12-03 05:12, Michael Paquier wrote:
> On Mon, Dec 02, 2019 at 10:11:40AM -0500, Tom Lane wrote:
>> One way would be to provide a variant expected-file, but that's not going
>> to be fun for future maintenance of the test script. Another simple
>> answer is to crank up client_min_messages for this one test to hide the
>> WARNING, but you could conjure scenarios where that misses something
>> important. (Of course, not running the test at all would also miss
>> any such issue.)
>
> Alternate output files should be IMO avoided if we can, so if I were
> to choose sneaking a SET client_min_messages would be fine, but only
> for the second create tablespace..
Fixed that way. I didn't realize it was a warning that could be
silenced that way.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2019-12-03 10:07:08 | pgsql: Fix thinkos from commit 9989d37 |
| Previous Message | Peter Eisentraut | 2019-12-03 08:28:47 | pgsql: Fix alter_system_table test |