Re: PATCH: regular logging of checkpoint progress

From: "Tomas Vondra" <tv(at)fuzzy(dot)cz>
To: "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "Tomas Vondra" <tv(at)fuzzy(dot)cz>, "Magnus Hagander" <magnus(at)hagander(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: PATCH: regular logging of checkpoint progress
Date: 2011-09-02 15:10:12
Message-ID: 93225ed61ca62fa906649233eb88ce75.squirrel@sq.gransy.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2 Září 2011, 16:13, Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> On fre, 2011-09-02 at 11:01 +0200, Tomas Vondra wrote:
>>> What about logging it with a lower level, e.g. NOTICE instead of the
>>> current LOG? If that's not a solution then a new GUC is needed I
>>> guess.
>
>> Changing the log level is not the appropriate solution. Make it a
>> configuration parameter.
>
> Frankly, logging as verbose as this is proposed to be is something
> that I can't imagine anybody wanting at all, especially not in
> production environments. DEBUG3 or somewhere around there seems fine.

Yes, it can be a bit verbose, but I don't think it's that verbose. I'm one
of those this information about checkpoint progress may be a valuable info
- even on production systems - that's why I don't want to put that into
the debug levels.

It should write about 10 lines for each checkpoint (altough I've just
realized the current patch won't do that for the timed checkpoints - it'll
probably log significantly more).

My 'ideal' solution would be either to add another GUC (to turn this
on/off) or allow log_checkpoints to have three values

log_checkpoints = {off, normal, detailed}

where 'normal' provides the current output and 'detail' produces this much
verbose output.

Tomas

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2011-09-02 15:13:03 Re: PATCH: regular logging of checkpoint progress
Previous Message Magnus Hagander 2011-09-02 15:08:45 Re: PATCH: regular logging of checkpoint progress