Re: pg_do_encoding_conversion glitch

ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Do you have a proposal for a different API, or do you just want to
>> improve the comment for the function? Bear in mind that a lot of the
>> callers do know the string length, and so we shouldn't impose an
>> unnecessary strlen() operation on those cases.

> We already have the following comment, so I think a new comment is
> not needed.
> | In the case of no conversion, src is returned.

I added a few more lines just to help people out --- in digging around
earlier today, there seemed to be a few places that hadn't been very
careful about this.

regards, tom lane