| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Nathan Bossart <nathandbossart(at)gmail(dot)com>, Noah Misch <noah(at)leadboat(dot)com> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, robertmhaas(at)gmail(dot)com, masao(dot)fujii(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: remove more archiving overhead |
| Date: | 2022-08-02 11:23:35 |
| Message-ID: | 9245a010-1f2e-af05-6268-c049934a55d0@pgmasters.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 8/2/22 01:02, Nathan Bossart wrote:
> On Sat, Jul 30, 2022 at 11:51:56PM -0700, Noah Misch wrote:
>> Inviting the administrator to resolve things is more dangerous than just
>> returning true. I recommend making this text more opinionated and simpler:
>> libraries must return true. Alternately, if some library has found a good
>> reason to return false, this paragraph could give the reason. I don't know of
>> such a reason, though.
>
> Your suggestion seems reasonable to me. I've attached a small patch.
+1. I think this is less confusing overall.
Regards,
-David
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Junwang Zhao | 2022-08-02 11:27:30 | [PATCH] Add a inline function to eliminate duplicate code |
| Previous Message | David Rowley | 2022-08-02 11:21:04 | Re: Add proper planner support for ORDER BY / DISTINCT aggregates |