Re: pgsql: Implement PREPARE AS statement for ECPG.

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Implement PREPARE AS statement for ECPG.
Date: 2019-05-22 10:06:36
Message-ID: 9195dfa03b9fd943ade91baf651a624f87582838.camel@postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

> This is a new feature and not a bug fix, hence why has this been
> committed to HEAD knowing that the feature freeze of v12 is effective
> as of the 8th of April? You should have waited until REL_12_STABLE
> has been created for new features.

Please see the thread on hackers. Yes, it is a new feature but that
part is small, the bigger impact is that this patch fixing a
prepare/execute implementation that was completely broken. By adding
new features here and there we managed to create an implementation that
did work well in some areas but surprisingly (unless you know the
source code) failed with minor change to the underlying statement.

That's why I committed it despite being late in the cycle. And because
it only has an impact on an interface not the backend itself.

Of course, if the consensus is to revert the patch until v13 I will
accept that.

> (The indentation of the new code in ecpglib/prepare.c is broken.)

What's wrong? I fixed the original one to stop my gcc from complaining,
but maybe I missed a piece.

Michael
--
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Meskes at (Debian|Postgresql) dot Org
Jabber: michael at xmpp dot meskes dot org
VfL Borussia! Força Barça! SF 49ers! Use Debian GNU/Linux, PostgreSQL

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2019-05-22 12:01:51 Re: pgsql: Make VACUUM accept 1 and 0 as a boolean value.
Previous Message Michael Paquier 2019-05-22 05:57:04 pgsql: Fix ordering of GRANT commands in pg_dump for database creation