| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Gin page deletion bug |
| Date: | 2013-11-08 17:14:26 |
| Message-ID: | 9195.1383930866@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> writes:
> I came up with the attached fix. In a nutshell, when walking along a
> right-link, the new page is locked before releasing the lock on the old
> one. Also, never delete the leftmost branch of a posting tree. I believe
> these changes are sufficient to fix the problem, because of the way the
> posting tree is searched:
This seems reasonable, but I wonder whether the concurrency discussion
shouldn't be in gist/README, rather than buried in a comment inside
ginDeletePage (not exactly the first place one would think to look IMO).
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2013-11-08 17:38:24 | Re: logical changeset generation v6.5 |
| Previous Message | Tom Lane | 2013-11-08 16:58:46 | Re: pgsql: Fix blatantly broken record_image_cmp() logic for pass-by-value |