Re: pgsql: Fix XMLTABLE on older libxml2

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> Fix XMLTABLE on older libxml2
> libxml2 older than 2.9.1 does not have xmlXPathSetContextNode (released
> in 2013, so reasonable platforms have trouble). That function is fairly
> trivial, so I have inlined it in the one added caller. This passes
> tests on my machine; let's see what the buildfarm thinks about it.

> Per joint complaint from Tom Lane and buildfarm.

Thanks, this works for me. At some point we might need to do this more
honestly, ie add a configure probe and do

#ifdef HAVE_XMLXPATHSETCONTEXTNODE
xmlXPathSetContextNode(cur, xtCxt->xpathcxt);
#else
xtCxt->xpathcxt->node = cur;
#endif

but that can probably wait until libxml does something that breaks
the direct-assignment coding. If the latter is the way you were
supposed to do it before, I think they'd be hesitant to break it.

regards, tom lane