Re: WIP Patch: Selective binary conversion of CSV file foreign tables

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp>
Cc: "'Kohei KaiGai'" <kaigai(at)kaigai(dot)gr(dot)jp>, "'Robert Haas'" <robertmhaas(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP Patch: Selective binary conversion of CSV file foreign tables
Date: 2012-07-12 20:30:14
Message-ID: 9173.1342125014@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Etsuro Fujita" <fujita(dot)etsuro(at)lab(dot)ntt(dot)co(dot)jp> writes:
> Besides the revision, I modified check_selective_binary_conversion() to run
> heap_close() in the whole-row-reference case. Attached is an updated version of
> the patch.

Applied with minor, mostly-cosmetic revisions. I did fix
check_selective_binary_conversion to not continue touching the
relation's tupledesc after heap_close. Also I thought
"convert_selectively" was a better name for the hidden COPY option.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Shaun Thomas 2012-07-12 20:40:55 Re: Synchronous Standalone Master Redoux
Previous Message Jeff Janes 2012-07-12 19:15:15 Re: DELETE vs TRUNCATE explanation