Re: Patch: create or replace language

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Andreas 'ads' Scherbaum" <adsmail(at)wars-nicht(dot)de>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Patch: create or replace language
Date: 2009-10-06 14:13:54
Message-ID: 917.1254838434@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Andreas 'ads' Scherbaum" <adsmail(at)wars-nicht(dot)de> writes:
> following this old discussion:
> http://archives.postgresql.org/pgsql-patches/2008-03/msg00402.php
> i modifies the patch to use the "CREATE [OR REPLACE] LANGUAGE" syntax.

This is not an "OR REPLACE" operation, because it doesn't replace
the existing definition. What you've got here is a CREATE IF NOT EXISTS
implementation that arbitrarily uses the other syntax. The point of
the previous discussion was summed up here:
http://archives.postgresql.org/pgsql-patches/2008-03/msg00416.php
namely that CREATE OR REPLACE should leave the object having the
properties specified in the command.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2009-10-06 14:24:50 Re: Patch: create or replace language
Previous Message KaiGai Kohei 2009-10-06 14:02:59 Re: [PATCH] DefaultACLs