Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented

2021-09-28 22:55 に Shinya11(dot)Kato(at)nttdata(dot)com さんは書きました:
>> -----Original Message-----
>> From: bt21tanigaway <bt21tanigaway(at)oss(dot)nttdata(dot)com>
>> Sent: Tuesday, September 28, 2021 5:06 PM
>> To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>;
>> pgsql-hackers(at)lists(dot)postgresql(dot)org
>> Subject: Re: (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet
>> implemented
>>
>> 2021-09-28 17:03 に bt21tanigaway さんは書きました:
>>> 2021-09-28 16:36 に Fujii Masao さんは書きました:
>>>> On 2021/09/28 16:13, bt21tanigaway wrote:
>>>>> Hi,
>>>>>
>>>>> (LOCK TABLE options) “ONLY” and “NOWAIT” are not yet implemented in
>>>>> tab-complete. I made a patch for these options.
>>>>
>>>> Thanks for the patch!
>>>> The patch seems to forget to handle the tab-completion for "LOCK
>>>> ONLY
>>>> <table-name> IN".
>>>
>>> Thanks for your comment!
>>> I attach a new patch fixed to this mail.
>>>
>>> Regards,
>>>
>>> Koyu Tanigawa
>>
>> Sorry, I forgot to attach patch file.
>> "fix-tab-complete2.patch" is fixed!
>>
>> Regards,
>>
>> Koyu Tanigawa
> Thank you for your patch.
> I have two comments.
>
> 1. When I executed git apply, an error occured.
> ---
> $ git apply ~/Downloads/fix-tab-complete2.patch
> /home/penguin/Downloads/fix-tab-complete2.patch:14: indent with spaces.
> COMPLETE_WITH_SCHEMA_QUERY(Query_for_list_of_tables, " UNION
> SELECT 'TABLE'" " UNION SELECT 'ONLY'");
> warning: 1 line adds whitespace errors.
> ---
>
Thank you for your feedback.
I might have added whitespace when I was checking the patch file.
I attach a new patch to this mail.

> 2. The command "LOCK TABLE a, b;" can be executed, but tab-completion
> doesn't work properly. Is it OK?
It's OK for now.
But it should be able to handle a case of multiple tables in the future.

Regards,

Koyu Tanigawa