| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz>, Jeff Davis <pgsql(at)j-davis(dot)com> |
| Cc: | Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, "Hayato Kuroda (Fujitsu)" <kuroda(dot)hayato(at)fujitsu(dot)com>, Shubham Khanna <khannashubham1197(at)gmail(dot)com>, Dilip Kumar <dilipbalaut(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Improve eviction algorithm in ReorderBuffer |
| Date: | 2024-04-10 05:30:22 |
| Message-ID: | 91098347-c594-486d-9c19-26481125a399@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 10/04/2024 07:45, Michael Paquier wrote:
> On Tue, Apr 09, 2024 at 09:16:53PM -0700, Jeff Davis wrote:
>> On Wed, 2024-04-10 at 12:13 +0900, Michael Paquier wrote:
>>> Wouldn't the best way forward be to revert
>>> 5bec1d6bc5e3 and revisit the whole in v18?
>>
>> Also consider commits b840508644 and bcb14f4abc.
>
> Indeed. These are also linked.
I don't feel the urge to revert this:
- It's not broken as such, we're just discussing better ways to
implement it. We could also do nothing, and revisit this in v18. The
only must-fix issue is some compiler warnings IIUC.
- It's a pretty localized change in reorderbuffer.c, so it's not in the
way of other patches or reverts. Nothing else depends on the binaryheap
changes yet either.
- It seems straightforward to repeat the performance tests with whatever
alternative implementations we want to consider.
My #1 choice would be to write a patch to switch the pairing heap,
performance test that, and revert the binary heap changes.
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2024-04-10 05:31:53 | Re: Improve eviction algorithm in ReorderBuffer |
| Previous Message | Tom Lane | 2024-04-10 05:18:26 | Re: Incorrect handling of IS [NOT] NULL quals on inheritance parents |