| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Clean up MinGW def file generation |
| Date: | 2019-10-20 08:26:40 |
| Message-ID: | 90cd400d-16a7-67c9-777f-3aea58edacb0@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2019-10-18 15:00, Tom Lane wrote:
> Yeah, the comment that Peter complained about is mine. I believe the
> desire to avoid depending on "sed" at build time was focused on our
> old support for building libpq with Borland C (and not much else).
> Since this makefile infrastructure is now only used for MinGW, I agree
> we ought to be able to quit shipping those files in tarballs.
Yeah, it all makes sense now. I have committed my patch now.
> I think there could be some .gitignore cleanup done along with this.
> Notably, I see exclusions for /exports.list in several places, but no
> other references to that name --- isn't that an intermediate file that
> we used to generate while creating these files?
exports.list is built from exports.txt on non-Windows platforms and
AFAICT it is not cleaned up as an intermediate file. So I think the
current arrangement is correct.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Floris Van Nee | 2019-10-20 08:39:58 | jsonb_set() strictness considered harmful to data |
| Previous Message | Peter Eisentraut | 2019-10-20 08:01:09 | Re: Remove obsolete information schema tables |