From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
---|---|
To: | "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com> |
Cc: | Julien Rouhaud <rjuju123(at)gmail(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Andrew Dunstan <andrew(at)dunslane(dot)net>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: possibility to read dumped table's name from file |
Date: | 2023-03-06 21:20:32 |
Message-ID: | 9069E332-4D38-4BBE-B527-3D9D4A11912E@yesql.se |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
> On 6 Mar 2023, at 21:45, Gregory Stark (as CFM) <stark(dot)cfm(at)gmail(dot)com> wrote:
>
> So.... This patch has been through a lot of commitfests. And it really
> doesn't seem that hard to resolve -- Pavel has seemingly been willing
> to go along whichever way the wind has been blowing but honestly it
> kind of seems like he's just gotten drive-by suggestions and he's put
> a lot of work into trying to satisfy them.
Agreed.
> He implemented --include-tables-from-file=... etc. Then he implemented
> a hand-written parser for a DSL to select objects, then he implemented
> a bison parser, then he went back to the hand-written parser.
Well, kind of. I was trying to take the patch to the finishing line but was
uncomfortable with the hand written parser so I implemented a parser in Bison
to replace it with. Not that hand-written parsers are bad per se (or that my
bison parser was perfect), but reading quoted identifiers across line
boundaries tend to require a fair amount of handwritten code. Pavel did not
object to this version, but it was objected to by two other committers.
At this point [0] I stepped down from trying to finish it as the approach I was
comfortable didn't gain traction (which is totally fine).
Downthread from this the patch got a lot of reviews from Julien with the old
parser back in place.
> Can we get some consensus on whether the DSL looks right
I would consider this pretty settled.
> and whether the hand-written parser is sensible.
This is the part where a committer who wants to pursue the hand-written parser
need to step up. With the amount of review received it's hopefully pretty close.
--
Daniel Gustafsson
[0] 098531E1-FBA9-4B7D-884E-0A4363EEE6DF(at)yesql(dot)se
From | Date | Subject | |
---|---|---|---|
Next Message | Daniel Gustafsson | 2023-03-06 21:24:30 | Re: On login trigger: take three |
Previous Message | Nathan Bossart | 2023-03-06 21:13:37 | Re: add PROCESS_MAIN to VACUUM |