Re: PostgreSQL 12: Cryptic documentation

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Robert Inder <robert(at)interactive(dot)co(dot)uk>, Pg Docs <pgsql-docs(at)lists(dot)postgresql(dot)org>
Subject: Re: PostgreSQL 12: Cryptic documentation
Date: 2020-08-15 16:38:47
Message-ID: 904676.1597509527@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

"David G. Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com> writes:
> As with most things there is always room for improvement. In this case,
> though, I'm not seeing anything wrong with the direct wording provided.

Also, it's under a heading that says "The following command-line options
control the location and format of the output", which ought to make it
clear that it's not about the source server's WAL dir. (Although I notice
that whoever added the --max-rate parameter didn't read that heading :-()

Still, I see that the main -D parameter is described as "Directory to
write the output to", which seems like a clearer phrasing, so I'm inclined
to similarly reword the description of --waldir.

A more direct criticism of the --waldir description is that it's not
stated what happens if you don't provide that argument.

I notice some shaky grammar and other minor annoyances in this page,
so I'm kind of inclined to make an editorial pass over the whole thing.

regards, tom lane

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message Tom Lane 2020-08-16 21:26:40 Inaccurate description of UNION/CASE/etc type selection
Previous Message David G. Johnston 2020-08-15 16:21:54 Re: PostgreSQL 12: Cryptic documentation