| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Teach pg_upgrade test to honor NO_TEMP_INSTALL |
| Date: | 2019-03-30 21:48:26 |
| Message-ID: | 9041.1553982506@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
> On some machines (*cough* Mingw *cough*) installs are very slow. We've
> ameliorated this by allowing temp installs to be reused, but the
> pg_upgrade Makefile never got the message. Here's a patch that does
> that. I'd like to backpatch it, at least to 9.5 where we switched the
> pg_upgrade location. The risk seems appropriately low and it only
> affects our test regime.
I haven't tested this, but it looks reasonable.
I suspect you need double-quotes around the path values, as in
the adjacent usage of EXTRA_REGRESS_OPTS.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2019-03-30 22:43:33 | clean up docs for v12 |
| Previous Message | Andres Freund | 2019-03-30 21:45:05 | Re: pgsql: Compute XID horizon for page level index vacuum on primary. |