Re: CVS compile failure

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: CVS compile failure
Date: 2004-07-19 05:10:33
Message-ID: 9040.1090213833@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

"Marc G. Fournier" <scrappy(at)postgresql(dot)org> writes:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
>> I am seeing a compile failure in current CVS from strptime():
>> ./backend/access/transam/xlog.c: if (strptime(tok2, "%Y-%m-%d %H:%M:%S", &tm) == NULL)
>> BSD/OS does not have that function.

> Under FreeBSD:
> " The strptime() function does not correctly handle multibyte characters in
> the format argument"
> Not sure how critical that is for what you are doing, mind you ...

Not at all, since in this call the format is the fixed constant
"%Y-%m-%d %H:%M:%S". But it's odd that your BSD variant has strptime()
where Bruce's does not.

I suppose it doesn't much matter though: we have to recode without
strptime. No big deal. I'll fix it tomorrow if no one beats me to it.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2004-07-19 06:39:03 Re: [HACKERS] Point in Time Recovery
Previous Message Marc G. Fournier 2004-07-19 05:03:07 Re: CVS compile failure