Re: v13 latest snapshot build error

On 3/12/2020 11:52 AM, Tom Lane wrote:
> Artur Zakirov <zaartur(at)gmail(dot)com> writes:
>> I'm not familiar with the patch itself. But I think there is just a lack
>> of the comma here, after ", /tmp" :-)
>
> [ blink... ] There definitely is a comma there in the version of the
> patch that's in the Fedora repo.

Ah, I see. I just saw the version Devrim sent (not sure that it is used
in the Fedora repo):

https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blob;f=rpm/redhat/master/postgresql-13/master/postgresql-13-var-run-socket.patch;h=a0292a80ae219b4c8dc1c2e686a3521f02b4330d;hb=HEAD

And I thought there should be a comma at the end of the line after
concatenation to avoid concatenation with NULL:

DEFAULT_PGSOCKET_DIR ", /tmp"

> {
> {"unix_socket_directories", PGC_POSTMASTER, CONN_AUTH_SETTINGS,
> gettext_noop("Sets the directories where Unix-domain sockets will be created."),
> NULL,
> GUC_SUPERUSER_ONLY
> },
> &Unix_socket_directories,
> #ifdef HAVE_UNIX_SOCKETS
> DEFAULT_PGSOCKET_DIR ", /tmp"
> #else
> "",
> #endif
> NULL, NULL, NULL
> },

--
Artur