| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Markus Wanner <markus(dot)wanner(at)enterprisedb(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | exclusion(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: fix crash with Python 3.11 |
| Date: | 2022-07-18 19:09:54 |
| Message-ID: | 8fb2d18a-1ddd-4762-729a-9685d82c5e96@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 23.06.22 09:41, Markus Wanner wrote:
>
> On 6/21/22 18:33, Tom Lane wrote:
>> My inclination at this point is to not back-patch the second change
>> 12d768e70 ("Don't use static storage for
>> SaveTransactionCharacteristics").
>> It's not clear that the benefit would be worth even a small risk of
>> somebody being unhappy about the API break.
>
> Actually, the backport of 2e517818f ("Fix SPI's handling of errors")
> already broke the API for code using SPICleanup, as that function had
> been removed. Granted, it's not documented, but still exported.
>
> I propose to re-introduce a no-op placeholder similar to what we have
> for SPI_start_transaction, somewhat like the attached patch.
I have applied your patch to branches 11 through 14.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2022-07-18 19:22:25 | Re: [Commitfest 2022-07] Begins Now |
| Previous Message | Andrew Dunstan | 2022-07-18 19:09:39 | Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size |