Re: making EXPLAIN extensible

From: Andrei Lepikhov <lepihov(at)gmail(dot)com>
To: Sami Imseih <samimseih(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jeff Davis <pgsql(at)j-davis(dot)com>, Thom Brown <thom(at)linux(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: making EXPLAIN extensible
Date: 2025-03-20 07:03:58
Message-ID: 8e8b6f17-e1e6-4b16-84d4-37ded802c787@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 19/3/2025 21:51, Sami Imseih wrote:
>> Why do you think this hook is not redundant?
> what is it redundant with?
>
>> It would be better to add the parameter "type: EXPLAIN_ONLY |
>> ANALYZE_ONLY | BOTH" to the RegisterExtensionExplainOption() routine.
>> This value will be saved inside the ExplainExtensionOption structure and
>> processed by the core inside the ParseExplainOptionList.
>
> hmm, IIUC, what you are describing is flag that will be limited to
> only check if an option can be used with EXPLAIN_ONLY, ANALYZE_ONLY
> or both. But what about if I have a case to check against between other
> extension options? let's say ExtensionAOptionA and ExtensionAoptionB.
> How would that work with the way you are suggesting?
That makes sense. It would be more effective to include the meaningful
example in Robert's extension for v7-0001.

I'm sorry, I was confused; previously, the difficulties faced by
extension developers were always attributed to him (refer to the
discussion on the selectivity hook). However, now you're introducing a
hook for a trivial operation that could simply be resolved at the end of
execution within a per-node hook with tiny inconsistency in output. I'm
pleased to see a change in the narrative.

--
regards, Andrei Lepikhov

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Nisha Moond 2025-03-20 07:05:53 Re: Conflict detection for multiple_unique_conflicts in logical replication
Previous Message David Rowley 2025-03-20 06:02:16 Re: Memoize ANTI and SEMI JOIN inner