Re: WIP: Deferrable unique constraints

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)googlemail(dot)com>
To: David Fetter <david(at)fetter(dot)org>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Jeff Davis <pgsql(at)j-davis(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: WIP: Deferrable unique constraints
Date: 2009-07-20 16:24:16
Message-ID: 8e2dbb700907200924l3cb4ad73g25f398261e98c8b4@mail.gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

2009/7/20 David Fetter <david(at)fetter(dot)org>:
> On Mon, Jul 20, 2009 at 10:21:53AM -0400, Tom Lane wrote:
>> Dean Rasheed <dean(dot)a(dot)rasheed(at)googlemail(dot)com> writes:
>> >> * Please move the code that says that it should be in a new file to a
>> >>  new file.
>>
>> > Ah yes, I forgot about that. Will do.
>>
>> > utils/adt/constraints.c ?
>>
>> Please, no.  Constraints are not a datatype.  Do not copy the brain-dead
>> decision that put ri_triggers there.
>
> Does that mean ri_triggers should come out of there?
>

The same argument could be applied to ruleutils.c, trigfuncs.c and perhaps
one or two others.

And if not there, where then?

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Kevin Grittner 2009-07-20 16:32:22 Re: Review: Revise parallel pg_restore's scheduling heuristic
Previous Message Kevin Grittner 2009-07-20 16:23:33 Re: Review: Revise parallel pg_restore's scheduling heuristic