| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | alvherre(at)2ndquadrant(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Review for GetWALAvailability() |
| Date: | 2020-06-19 08:23:24 |
| Message-ID: | 8dcae742-7892-ad82-b787-1ac05cb878d8@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/06/18 16:36, Kyotaro Horiguchi wrote:
> Mmm. I hurried too much..
>
> At Thu, 18 Jun 2020 16:32:59 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
>> If name is specified (so slot is NULL) to
>> ReplicationSlotAcquireInternal and the slot is not found, the ereport
>> in following code dereferences NULL.
>
> That's bogus. It is using name in that case. Sorry for the noise.
>
> I don't find a problem by a brief look on it.
Thanks for the review! I pushed the patch.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2020-06-19 08:24:01 | hash as an search key and hash collision |
| Previous Message | Andrey V. Lepikhov | 2020-06-19 08:11:59 | Re: Global snapshots |