Re: pgsql: Restrict accesses to non-system views and foreign tables during

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Restrict accesses to non-system views and foreign tables during
Date: 2024-08-27 12:41:39
Message-ID: 8dbff88c-d1cc-4c4d-a016-1c538c7cf9bd@eisentraut.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 26.08.24 21:05, Masahiko Sawada wrote:
> Maybe using the word "prohibit" makes it a bit clear? For example,

I think that would be much clearer, yes.

> In guc_tables.c:
> Prohibits access to non-system relations of specified kinds

End with period.

> In doc:
> Set relation kinds of non-system relations to which access is
> prohibited.

Still a bit awkward. Maybe "Set relation kinds for which access to
non-system relations is prohibited."

> It takes a comma-separated list of relation kinds.
> Currently, the supported relation kinds are view and foreign-table.

Maybe in the documentation it would also be appropriate to mention that
this is meant to be used by pg_dump, not for general use -- unless it is?

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-08-27 13:29:43 Re: pgsql: Restrict accesses to non-system views and foreign tables during
Previous Message Masahiko Sawada 2024-08-26 23:17:56 pgsql: Fix identation.